search

nilsbraden / ttrss-reader-fork

An Android-Client for the self-hosted Tiny Tiny RSS feedreader
https://www.nilsbraden.de/TTRSS-Reader/
149 stars 40 forks source link

configure sslSocketFactory for OkHttp #436

Closed artbristol closed 3 years ago

artbristol commented 3 years ago

Client certificate connections have been broken for a few months now. I think it's because the config for the new OkHttp library didn't include anything to do with TLS. I've added that in this PR

In passing, I think the UI doesn't make it clear that if you select client certificate authentication, your settings for "Accept all certificates" and "Trust All Hosts" are ignored. (Unless I'm misreading the code)

artbristol commented 3 years ago

@nilsbraden any chance you could take a look? The app's been broken for me for a long time now.

nilsbraden commented 3 years ago

Sorry I missed that pull request. Looks good to me, thanks für sharing this.

I need to look into the other settings, you are right. I'll leave this open for this issue...