nilsbraden / ttrss-reader-fork

An Android-Client for the self-hosted Tiny Tiny RSS feedreader
https://www.nilsbraden.de/TTRSS-Reader/
150 stars 40 forks source link

A network request is not being handled on failure #455

Open amazuerar opened 3 years ago

amazuerar commented 3 years ago

Dear Developer!

My name is Alejandro Mazuera-Rozo, I am a PhD Student at Universidad de los Andes, and at Università della Svizzera italiana. I am part of a research on the usage of network libraries within Android apps. As result of this we identified some code locations that might have network related problems.

In this case, we address the code locations that are related to a network request which is not being assessed on failure. In order to avoid misbehaviour when performing network operations it is recommended to handle failure scenarios.

In order to address this issue we recommend:

  1. To implement the catch statement in which one defines a block of code to be executed if an error occurs.

Potential Code Location not handling failure scenarios when performing a network request

https://github.com/nilsbraden/ttrss-reader-fork/blob/84900122b132aa3c0b07b97f720e6bf5fc203592/ttrssreader/src/main/java/org/ttrssreader/utils/Utils.java#L400-L421