Open ParadaCarleton opened 2 years ago
All these functionalities seem to be better placed in TreatmentPanels.jl as (at least currently) I do not see anything that requires changes in DataFrames.jl (but I might be wrong - let us see how the thread evolves).
All these functionalities seem to be better placed in TreatmentPanels.jl as (at least currently) I do not see anything that requires changes in DataFrames.jl (but I might be wrong - let us see how the thread evolves).
I actually agree. In fact, I think DataFrames.jl already mostly implements everything we'd need. The only thing I think would be good to add in DataFrames.jl is a constructor taking a grouped DataFrame where one of the columns is a date.
a constructor taking a grouped
DataFrame
where one of the columns is a date.
What output would you expect then? DataFrame
constructor already accepts GroupedDataFrame
as an argument.
a constructor taking a grouped
DataFrame
where one of the columns is a date.What output would you expect then?
DataFrame
constructor already acceptsGroupedDataFrame
as an argument.
It'd output a Panel
/TreatmentPanel
, preferably without copying the underlying data -- I assume it should be possible to allow for an arbitrary underlying data source using the Table
interface and something like MLUtils.
Some things that might be necessary for a generic panel data interface:
obsview
in MLUtils. Perhapscross_section
andtime_series
?@bkamins