search

nilskp / jmh-charts

Charts for JMH benchmarks
https://nilskp.github.io/jmh-charts
MIT License
10 stars 1 forks source link

Add params as label qualifier #1

Closed ben-manes closed 9 years ago

ben-manes commented 9 years ago

In a comparison benchmark using @Param to parameterize the same benchmark routine, the generated chart labels are all the same. This makes sense as the benchmark names are equal, but the parameters differentiate the results. The chart is unfortunately unreadable due to this issue for this style of benchmarking.

nilskp commented 9 years ago

Can you attach a sample JSON file? I haven't yet run with @Param.

ben-manes commented 9 years ago

Here's an example benchmark comparing the concurrent throughput of two cache implementations.

results.json | uploaded via ZenHub

nilskp commented 9 years ago

Thanks. Any chance I can also see the source code?

ben-manes commented 9 years ago

Its a trimmed down version of the results from this GetPutBenchmark.

nilskp commented 9 years ago

Great example, thanks.

I assume JMH creates a cartesian set of all @Params, is that right?

It's going to take a few days before I have time to look into this.

ben-manes commented 9 years ago

Yep.

No rush, thanks for the charts.