search

nilslice / protolock

Protocol Buffer companion tool. Track your .proto files and prevent changes to messages and services which impact API compatibility.
https://protolock.dev
BSD 3-Clause "New" or "Revised" License
600 stars 36 forks source link

Website incorrectly reports backwards compatibility with invalid proto files #123

Open DarrienG opened 5 years ago

DarrienG commented 5 years ago

My guess is this is the proper place to post issues for the website protolock.dev If it isn't, feel free to point me somewhere else.

Go to protolock.dev, hit the init button. Make an incompatible change to the proto file (e.g. change SERVICE_UNKNOWN = 3 -> SERVICE_UNKNOWN = 9) and then make the proto file invalid, e.g. s/rpc/dog/g and it will mark it as backwards compatible.

This actually isn't the case with the CLI:

$ protolock status         
[protolock]: root.proto:17:5: found "dog" but expected [service comment|rpc]

So I figure this is a bug.

nilslice commented 5 years ago

@DarrienG -- thanks for reporting! I'll try to reproduce and then update the WASM binary to a version built with the latest protolock code.

Can you tell me a bit more about your environment? Which browser and OS (and their versions) are you using?

DarrienG commented 5 years ago

Glad I can help! I love the product.

It happens on Firefox v69/70 on macOS Catalina.