Update parse to handle enum options

nilslice / protolock

Protocol Buffer companion tool. Track your .proto files and prevent changes to messages and services which impact API compatibility.

https://protolock.dev

BSD 3-Clause "New" or "Revised" License

604 stars 37 forks source link

Update parse to handle enum options #138

Closed johnfishbein closed 2 years ago

johnfishbein commented 2 years ago

Hey @nilslice, finally got around to working through this. This fixes #135

One thing to note- it seems like the AllowAlias field in the Enum object doesn't actually get populated. I left it in there in case any plugin relies on it, but the Options field now encapsulates that logic.

nilslice commented 2 years ago

Hi @johnfishbein - thanks for the PR! I will get a review in ASAP. The CI builds have been busted for a while and I haven't carved out the time to fix them. I'll probably end up manually testing this, so it isn't blocked by the automation. I'll ping you here with any questions.

nilslice commented 2 years ago

Merged - thank you!