Closed rubengees closed 4 years ago
Awesome! I will have a look at it later today, but this looks really good :+1:
Cool, thanks!
What would be the minimum Gradle version this plugin should support? I have checked (and added tests) that we support Gradle 4.10+ with this PR. Do we need to go lower? If we do, I'd add some compat methods that check for the Gradle version and call older APIs.
@nilsmagnus Friendly ping :) Did you find any time to check this?
Sorry for the delay :)
LGTM, thanks for the contribution. I added you to the collaborators so you can fix minor things without my approval :)
This is great work!
Will await the next published release :)
This has a lot of breaking changes, no migration steps, and no changelog. Please be kinder to your users as a lot of behavior no longer works correctly in a Goovy build. I'm not exactly excited to reverse engineer your code to upgrade my usage.
You are right, sorry for that.
This is a major refactor of the plugin to support modern Gradle versions.
The goals are:
wsdl2java
).sourceSets
.cxf
and needed ones for Java 9+ support).Code Changes
Wsdl2JavaPlugin
wsdl2java
configuration and thecompile
configuration.sourceSets
before we get the setting from the user.Wsdl2JavaTask
@CacheableTask
(which allows Gradle's build cache to work).Clean task
Structure
consumer
project into a test project undersrc/test/resources/test-project
and added Gradle TestKit tests for it.This contains at least the following breaking changes:
generatedWsdlDir
property removed and default changed.wsdlDir
default changed.