nilsmagnus / wsdl2java

Gradle plugin for generating java source from wsdl files
MIT License
143 stars 77 forks source link

Refactor project for modern Gradle #95

Closed rubengees closed 4 years ago

rubengees commented 4 years ago

This is a major refactor of the plugin to support modern Gradle versions.

The goals are:

Code Changes

Wsdl2JavaPlugin
Wsdl2JavaTask
Clean task
Structure

This contains at least the following breaking changes:

nilsmagnus commented 4 years ago

Awesome! I will have a look at it later today, but this looks really good :+1:

rubengees commented 4 years ago

Cool, thanks!

What would be the minimum Gradle version this plugin should support? I have checked (and added tests) that we support Gradle 4.10+ with this PR. Do we need to go lower? If we do, I'd add some compat methods that check for the Gradle version and call older APIs.

rubengees commented 4 years ago

@nilsmagnus Friendly ping :) Did you find any time to check this?

nilsmagnus commented 4 years ago

Sorry for the delay :)

LGTM, thanks for the contribution. I added you to the collaborators so you can fix minor things without my approval :)

KrauseStefan commented 4 years ago

This is great work!

Will await the next published release :)

ben-manes commented 3 years ago

This has a lot of breaking changes, no migration steps, and no changelog. Please be kinder to your users as a lot of behavior no longer works correctly in a Goovy build. I'm not exactly excited to reverse engineer your code to upgrade my usage.

rubengees commented 3 years ago

You are right, sorry for that.