search

nilsnolde / docker-valhalla

This is our flexible Docker repository for the Valhalla routing engine
MIT License
257 stars 74 forks source link

valhalla latest code crashes at build stage for (maybe) large regions #166

Closed answerquest closed 1 month ago

answerquest commented 2 months ago

Ref: https://github.com/valhalla/valhalla/issues/4904

Latest ghcr.io/gis-ops/docker-valhalla/valhalla:latest image is crashing out at build stage. I got the same error result for Africa and Europe continent builds.

It's not fully known yet at what point the problem crept into valhalla source code; but it would be great if someone can find out and then pin this docker image on the last stable commit.

chrstnbwnkl commented 2 months ago

Let's see if we can quickly fix this upstream, I doubt it will take very long to hunt this down

nikhil-scholarlify commented 2 months ago

one procedural thing that might be important in such cases: valhalla original repo has a v3.5.0 release from Aug 21, but this repo's docker release doesn't have a corresponding 3.5.0 tag that we could fallback to, whereas prior release's 3.4.0 tag is there. possible to make a 3.5.0 tag while the bug gets sorted out? There might be a chance that it's not carrying the bug.

answerquest commented 2 months ago

Query: in this repo, in the Dockerfile, If I change ARG VALHALLA_BUILDER_IMAGE=ghcr.io/valhalla/valhalla:latest to ARG VALHALLA_BUILDER_IMAGE=ghcr.io/valhalla/valhalla:3.5.0 and do docker build, then will that take the 3.5.0 release of valhalla? any other place any more change to make?

chrstnbwnkl commented 2 months ago

that should be good, though from the discussion it seems likely that 3.5.0 already carries the bug, so another easy option for now would be to use 3.4.0, for which there is a tagged version (i know it's relatively old, but it's just until this gets sorted out)

chrstnbwnkl commented 1 month ago

I'm closing this issue since it's related to the upstream. In any case, 3.5.0 and 3.5.1 tags are now available, but I'm afraid the change that's causing this issue has been made a while back.