search

nilsnolde / docker-valhalla

This is our flexible Docker repository for the Valhalla routing engine
MIT License
257 stars 74 forks source link

allow using custom fork for valhalla #171

Closed farfromrefug closed 3 days ago

farfromrefug commented 4 weeks ago

Could be useful to use custom branches /repo of valhalla while PRs are being reviewed or before release Not sure if possible.

BTW: how do we know which version of valhalla is actually used? latest, master?

THanks

chrstnbwnkl commented 3 days ago

Not sure GitHub Actions supports event triggers that would be necessary. Also, PR branches in the upstream repo don't build the docker image either. I simply do this in my custom forks (a Valhalla fork where pushes to PR branches trigger a docker build, and a fork of this repo that in turn builds based off my fork :smile:). I wouldn't cram all this into the upstream repo.

We rebuild latest once every week from master, and have tagged releases for every Valhalla release. Last release was before this repo was moved away from GIS-OPS, so this one still has none.

farfromrefug commented 3 days ago

@chrstnbwnkl i do now maintain a fork of this repo and publish my own docker through github package as you do here. So i guess that could be the way to go