nilsnolde / docker-valhalla

This is our flexible Docker repository for the Valhalla routing engine
MIT License
257 stars 74 forks source link

Comparison of the docker-images of valhalla #174

Closed danceb closed 6 days ago

danceb commented 1 week ago

Hey there,

I came back after some months to update our valhalla instance. Since now I have used the docker image from ghcr.io/gis-ops/docker-valhalla/valhalla, as there was no other docker image from valhalla directly, as I remember. Now I have recognized, that there is no "gis-ops" image anymore. It seems it was replaced by the one I could find here: https://github.com/nilsnolde/docker-valhalla/pkgs/container/docker-valhalla%2Fvalhalla/, right?

Hint: The old repo is still linked here: https://github.com/nilsnolde/docker-valhalla?tab=readme-ov-file#dockerhubgithub-packages. Within the paragraph it is written, that you provide stable release, but I could only find a latest tag.

No there is also an "official" docker image, which could be found here with stable tags: https://github.com/valhalla/valhalla/pkgs/container/valhalla.

As you are also a maintainer of the vallhalla project itself: So what are the differences between yours and the other image? At https://github.com/valhalla/valhalla?tab=readme-ov-file#installation it os only written, that your image contains "more "magic" than the native one". But what is the magic?

If I used the gis-ops image with stable tags before, should I use your image with the latest tag instead to keep the system running with the same configuration as before?

Thanks for clarification!

chrstnbwnkl commented 6 days ago

The repository was simply moved from the GIS-OPS organization, and since there was no Valhalla release afterward, there are no tagged releases on the new, moved repo yet. We don't follow a strict release schedule right now, the last release was due to a bug fix that could have potentially messed with edge geometries.

I'd say you can stay on the 3.5.1 release of the old repo for now and wait until the next tagged release is available on the new one, if you don't want to use latest.

About the differences between the images: the "magic" (we should probably elaborate a bit more) merely includes an automatic graph build, some changes to the default config and an easy interface to control container behavior via environment variables. The official "vanilla" image does nothing except provide the built executables and libraries.

danceb commented 6 days ago

Ok, perfect, thank you!