nilsnolde / py-osrm

Python bindings to the OSRM routing framework
https://gis-ops.github.io/py-osrm/
BSD 2-Clause "Simplified" License
8 stars 8 forks source link

Add push, publish workflows #23

Closed whytro closed 1 year ago

whytro commented 1 year ago

Adding the push and publish workflows for this project. Marked as draft, as I would like to shift the CIBW commands back to the pyproject.toml file to cut down on code duplication, but also because the PyPI details need to be finalized as well (ie. user & secret).

nilsnolde commented 1 year ago

You could send me the password to the testing PyPI, then I add it to the secrets here.

BTW @SiarheiFedartsou how's npm handled there? ref https://github.com/Project-OSRM/osrm-backend/issues/6610#issuecomment-1686627839

whytro commented 1 year ago

Addresses #20

whytro commented 1 year ago

These further commits should address #14 .

The osrm executables were added as the __main__ of the osrm module. As a result, the osrm executables are accessible in the following manner:

Example for running osrm-datastore:

python -m osrm datastore <arguments>

An important thing of note is that the if(LibOSRM_FOUND) branch has an issue where the copied executables lack execute permissions.

nilsnolde commented 1 year ago

Great work @whytro!

An important thing of note is that the if(LibOSRM_FOUND) branch has an issue where the copied executables lack execute permissions.

That's strange, it seems to say that the file(COPY ..) command preserves input permissions: https://cmake.org/cmake/help/v3.27/command/file.html#copy.

whytro commented 1 year ago

I've also tried putting in additional arguments, such as USE_SOURCE_PERMISSIONS to no avail, so I'm not entirely sure of the cause.