search

nilsnolde / py-osrm

Python bindings to the OSRM routing framework
https://gis-ops.github.io/py-osrm/
BSD 2-Clause "Simplified" License
8 stars 8 forks source link

Fix FetchContent Install #24

Closed whytro closed 1 year ago

whytro commented 1 year ago

This fixes an issue where the FetchContent installs were not working on fresh runs. A downside of this is that when a wheel is created using FetchContent, other install targets are included into the wheel (ie. include files, share files, lib files), alongside the executables.

nilsnolde commented 1 year ago

how big is a wheel as a result of that?

whytro commented 1 year ago

Around 13.7 MB. It's not particularly large, but it does sort of add a bunch of unnecessary files to the install directory if built from source, and installed via FetchContent.

nilsnolde commented 1 year ago

We can live with that IMO. Let's also turn that into an issue. At least CI doesn't do that so it won't land on PyPI.