nilsnolde
commented
1 year ago This is awesome @whytro , very good job!
Should we enable the Windows wheel builds on PR CI runs, or leave it out since it's still 2x/3x the time taken compared to Mac or Linux?
I'd suggest the following for CI:
- in the PR one enable only linux, test all python versions, this is quick
- in master_push, test only 3.8, but all platforms, takes longer but is much less used
WDYT?
After we merged this, we can try another publishing to test PyPI. Once that's successful, we can switch to the real thing and it's a v0.0.1 for real:) That's a really good end of the project.
SiarheiFedartsou
Changes made:
__main__to search in more directories, and also look forosrm-datastoreorosrm-datastore.exe(since the previous default sitepackages dir was different on Windows unless the--userflag was specified).before-allto the pyproject.toml file to cut down on code duplication.osrm-datastore, and the test generation make/bat) have been moved to thetest-commandsection, as it requires the package to be installed due to reliance onpython -m osrm <executable>.Since the osrm-backend artifact workflow for Windows builds store the dependencies, building the actual wheel for Windows doesn't take too long - about 7~9 minutes. The osrm-backend artifact workflow for Windows takes like 40 minutes though. Should we enable the Windows wheel builds on PR CI runs, or leave it out since it's still 2x/3x the time taken compared to Mac or Linux?