search

nilsnolde / routingpy

🌎 Python library to access all public routing, isochrones and matrix APIs in a consistent manner.
https://routingpy.readthedocs.io/en/latest/?badge=latest
Apache License 2.0
272 stars 28 forks source link

feat: router for OpenTripPlanner #109

Closed khamaileon closed 1 year ago

khamaileon commented 1 year ago

image

khamaileon commented 1 year ago

Thanks you 🙂. This is only a first draft. I've already identified few improvements.

It's v2. You're right, it's better to specify it. Isochrone is implemented. Sorry, I had force-pushed and maybe you've only seen the first draft.

nilsnolde commented 1 year ago

Sure, no worries, I thought it was done for you. I converted your PR into a draft PR so it's clearer. Just un-draft it once you're ready:) Thanks!

khamaileon commented 1 year ago

Ah I thought I'd drafted it. Hence the misunderstanding thank you! Okay, it's ready now :)

nilsnolde commented 1 year ago

Sorry for the delay on this, I’ll have a look until the end of the week.

khamaileon commented 1 year ago

No worries, ty @nilsnolde

khamaileon commented 1 year ago

Thanks for the review. I'll let you do the merge :)

nilsnolde commented 1 year ago

Interesting, Github changed smth, usually it'd require a re-approve. Maybe bcs only the commented file changed..

Anyways, thanks, this is great!