search

nilsnolde / routingpy

🌎 Python library to access all public routing, isochrones and matrix APIs in a consistent manner.
https://routingpy.readthedocs.io/en/latest/?badge=latest
Apache License 2.0
272 stars 28 forks source link

Added the following routers: ArcGIS, Bing Maps, MapQuest, TomTom. #125

Closed roccoloconte closed 8 months ago

roccoloconte commented 8 months ago

I have written the directions method and how to read the JSON response. I do not know how to test it in your configurations but, for my MSc thesis, I wrote a personal project to get routing information also from these APIs and, using their free plan, it worked.

P.S. I have also written the Apple router but I have not tested it since it does not have a free plan and it requires putting the key into the header, not in base_url. Let me know if you want it anyway.

nilsnolde commented 8 months ago

That's a lot of work, kudos! A few years ago I'd have loved to include your PR. Then came reality and the crazy overhead of maintaining these things. I should've updated the repo to say we don't want any closed-source routing engines anymore, we only want OSS. Overall, I'm sorry to say that I wouldn't like to merge this. In worst case this should be fairly easy to maintain as a fork.

For future reference, I'd recommend to always first open an issue and ask if a contribution is of interest to the project.

roccoloconte commented 8 months ago

No worries, thank you for your response.

For future reference, I'd recommend to always first open an issue and ask if a contribution is of interest to the project.

Got it.