Closed jan-bausch closed 1 year ago
Jep right. They must've added POST a while ago. They went through 6 major versions in the past 2 years, can't keep up with that;)
We hardly ever work with Graphhopper, but would appreciate a PR fixing it.
Do you prefer
a) replacing the GET with the POST request alltogether, or b) adding an optional parameter to use the POST endpoint?
Intuitively, I'd go for a), as the endpoints should be interchangeable. What's your opinion?
Do you think GET is interesting for any scenario? Is there an action that's GET only or so? Valhalla has both too, but we only do POST since there's not GET-only ones. It'd be easiest here too IMO.
I agree 👍 Based on the docs, there are no drawbacks, and POST is clearly recommended.
I can work on a small PR, if I find the time 👌
Any chance for a quick review, @nilsnolde ?
was done in #91 & #92 , thanks again:)
Graphhopper supports both a
GET
and aPOST
directions endpoint. However, theGET
endpoint has some limitations:(Quote from the Graphhopper docs)
Currently, routingpy only supports the
GET
endpoint. It would be cool to usePOST
, to be able to set custom models!