nilsnolde / routingpy

🌎 Python library to access all public routing, isochrones and matrix APIs in a consistent manner.
https://routingpy.readthedocs.io/en/latest/?badge=latest
Apache License 2.0
272 stars 28 forks source link

Replace GET with POST and update unit tests #91

Closed jan-bausch closed 1 year ago

jan-bausch commented 1 year ago

This replaces calls to the Graphhopper directions API from GET to POST.

I've also updated the corresponding unit tests.

jan-bausch commented 1 year ago

I converted params into a dictionary, pluralized the relevant parameters and updated the corresponding unit test

Needs further work, depending on https://github.com/gis-ops/routingpy/pull/91#discussion_r1141971247

jan-bausch commented 1 year ago

I've updated a handful of arguments to be identical with the docs:

Renamed point_hint to point_hints, heading to headings, snap_prevention to snap_preventions, curb_side to curbsides,

Added custom_model parameter

Removed weighting, block_area, avoid, turn_costs parameters

chrstnbwnkl commented 1 year ago

Thanks, really appreciating help on this, hard to always keep up with all the API changes :)

nilsnolde commented 1 year ago

Ah damn, forgot that we have a changelog :sweat_smile: We'll get it before we release (likely this week)

jan-bausch commented 1 year ago

Awesome, thanks for the quick feedback 🎉