Closed Serphentas closed 1 year ago
Huh.. we just had a PR fixing some other GH things, I can’t imagine that didn’t work a few weeks back. Did they release another major version and changed it?
Jep, GH 7.0 removed the vehicle
parameter: https://github.com/graphhopper/graphhopper/blob/master/CHANGELOG.md#70-14-mar-2023
Good catch. Shall I go ahead with a PR ? I'm thinking about a version
parameter for the client initialization, or perhaps just the directions
method, to switch between vehicle
and profile
.
Shall I go ahead with a PR
that’d be great thanks!
I'm thinking about a version parameter for the client initialization
That’d be noble:) But I think we should just support whatever’s on their public API, since that’s a slippery slope. GH has twice a year major version upgrades currently, too much of a maintenance hassle to support all their deprecations to be honest.
See above, I followed your advice and simply replaced the key with no backwards support.
Done in #94
Here's what I did
A simple query, such as:
Here's what I got
No "profile" set, but a "vehicle" that GraphHopper doesn't accept:
Here's what I was expecting
The "profile" key to be set accordingly
Here's what I think could be improved
This line should be changed from
to
since no "vehicle" key exists in the GraphHopper API documentation.