search

nilsnolde / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
173 stars 98 forks source link

Switch leaflet for openlayers? #158

Open nilsnolde opened 1 year ago

nilsnolde commented 1 year ago

What would you like to share?

WDYT @chrstnbwnkl ?

I asked Stadia Maps if we can use their Alidade light style for background maps (they'd even bump our API key if necessary). While they of course have raster data as well, I'd prefer to then consume their MVT endpoint, it's just so much nicer for end users..

Apart from the fact (not really fact, but looks very much like it) that leaflet is at the very least carrying tech debt that's hard to overcome without a major re-write and can't see that happening anytime soon.

Uff, let's see, this seems to become a serious re-write of our app with the class -> functional React changes. It could be a bit messy to do it all at the same time, maybe first the full React re-write, then this?! We'll see, I just wanted to put it out there:)

chrstnbwnkl commented 1 year ago

Agree! Definitely a big work package, but probably worth the effort. We can just leave it here now and discuss it when GSoC starts :-)