nilsnolde / valhalla-app

This is the demo web app running on https://valhalla.openstreetmap.de
https://valhalla.openstreetmap.de
MIT License
170 stars 97 forks source link

Clean Up Repo Issue solved #143 #176

Closed shreyarora12 closed 1 year ago

shreyarora12 commented 1 year ago

🛠️ Fixes Issue

📄 Note to reviewers

Cleaner Code

📷 Screenshots

123

shreyarora12 commented 1 year ago

I came across the project sort of a bit late, that's why I missed it. I wanted to submit a proposal for the purpose of GSOC but since I was short on time I couldn’t. I’ll correct the issue right away.

On Sat, Apr 8, 2023 at 12:29 AM Nils @.***> wrote:

@.**** requested changes on this pull request.

This technically doesn't solve #143 https://github.com/gis-ops/valhalla-app/issues/143 entirely, but it does do a tiny bit of cleanup. I'd only ask to please revert the hex color change.

In src/index.css https://github.com/gis-ops/valhalla-app/pull/176#discussion_r1160879766:

@@ -34,7 +34,7 @@ i.help.grey.icon { .custom-label { font-size: 0.85em; font-weight: bold;

  • color: rgba(0, 0, 0, 0.87);
  • color: #000000de;

I'd like to revert this one, I find it much more legible to see the opacity in float rather than hex

— Reply to this email directly, view it on GitHub https://github.com/gis-ops/valhalla-app/pull/176#pullrequestreview-1376460993, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARGSFQBPTX2TVPYV5IURAEDXABPYJANCNFSM6AAAAAAWS7TDGY . You are receiving this because you authored the thread.Message ID: @.***>