Closed PrzemyslawKlys closed 3 years ago
tl;dr: this plugin can't render Github's extended Markdown syntax..
I think you got a little too used to Github markdown convenience;) That's extended syntax and, among other things, needs some JS to function properly. This plugin simply asks Github's markdown API for the HTML of your raw markdown files and returns that to Wordpress unaltered.
For
Currently if person uses:
- [x] Test
- [ ] Test2
with this curl
curl --location --request POST 'https://api.github.com/markdown/raw' \
--header 'Accept: application/vnd.github.v3+json' \
--header 'Content-Type: text/plain' \
--data-raw 'Currently if person uses:
- [x] Test
- [ ] Test2'
you'll get
<p>Currently if person uses:</p>
<ul>
<li>[x] Test</li>
<li>[ ] Test2</li>
</ul>
So it just returns a simple list, not even some special CSS classes one could use to catch them downstream. Compare that to the example above, i.e. how Github & your browser render it in HTML:
So it seems Github internally uses a much different renderer for Markdown than their API uses. That's a little annoying for me too, but I can live with it. It can't be changed unless you'd integrate with some markdown parsing library and I should add that we wouldn't accept a contribution like that in this repo.
It's not a problem. I'll switch to using emoji which seems to work
Thank you for this plugin - it's really amazing and will allow me to combine markdown content of all my projects with my Wordpress abilities! Here's what your plugin did: https://evotec.xyz/hub/scripts/pswritehtml-powershell-module/
Great workaround!:)
Versions Wordpress: 5.7 Documents for Git: 1.1.0
Describe the bug
Currently if person uses:
Only UL/LI is respected, and [x] is written down as standard text.
Paste the shortcode and the censored contents of config.json
shortcode
To Reproduce Steps to reproduce the behavior:
Expected behavior
I would expect some sort of replacement to be used, emoji or an icon (☑)
Screenshots
Keep in mind that my theme doesn't show UL/LI properly, but other themes do
Additional context