search

nilsnolde / wordpress-markdown-git

:loop: WordPress plugin to add file content (Markdown, Jupyter notebooks) from a Git based VCS to a WordPress post; replaces https://github.com/gis-ops/md-github-wordpress
GNU General Public License v3.0
48 stars 14 forks source link

call_user_func_array call - updated for PHP8 #34

Closed florinhoinarescu closed 3 years ago

florinhoinarescu commented 3 years ago

https://www.drupal.org/project/drupal/issues/3174022

Example:

replacing: call_user_func_array( 'add_settings_section', $params );

with: call_user_func_array( 'add_settings_section', array_values($params) );

nilsnolde commented 3 years ago

looks good, thanks a bunch!

let me know when this is ready from your side (maybe already?), then I'll try locally and merge.

florinhoinarescu commented 3 years ago

Yes it is ready from my side, seems that works well on my side, did not get any errors.

nilsnolde commented 3 years ago

sorry @florinhoinarescu for the long wait. I'll merge and then test, so I don't have to pull yours;) thanks again!

nilsnolde commented 3 years ago

works for me too!