search

nilsteampassnet / TeamPass

Collaborative Passwords Manager
https://www.teampass.net
1.66k stars 544 forks source link

Long time to upgrade from teampass 2.1.27.36 to 3 #4045

Open nyevess opened 8 months ago

nyevess commented 8 months ago
### Steps to reproduce 1. Download the latest version and copy the required files from the old folder to the new 2. Run the assistant /install/upgrade.php 3. Waiting for 4 hours and still running, no errors in apache logs. ### Expected behaviour Continue with the upgrade ### Actual behaviour Continue upgrading loop for a long long time ### Server configuration **Operating system** Ubuntu 18.04 **Web server:** Apache 2.4.41 **Database:** mysql **PHP version:** 8.1 **Teampass version:** 2.1.27.36 **Teampass configuration file:** "", "cert" => "", "ca_cert" => "", "ca_path" => "", "cipher" => "" )); define("DB_CONNECT_OPTIONS", array( MYSQLI_OPT_CONNECT_TIMEOUT => 10 )); define("SECUREPATH", "/var/teampass"); if (isset($_SESSION['settings']['timezone']) === true) { date_default_timezone_set($_SESSION['settings']['timezone']); } **Updated from an older Teampass or fresh install:** PLEASE attach to this issue the file `/includes/config/tp.config.php`. '10', 'enable_favourites' => '1', 'show_last_items' => '1', 'enable_pf_feature' => '1', 'log_connections' => '1', 'log_accessed' => '1', 'time_format' => 'H:i:s', 'date_format' => 'd/m/Y', 'duplicate_folder' => '0', 'item_duplicate_in_same_folder' => '0', 'duplicate_item' => '1', 'number_of_used_pw' => '3', 'manager_edit' => '1', 'cpassman_dir' => '/var/www/html/teampass', 'cpassman_url' => 'https://teampass.mydomain', 'favicon' => 'http://teampass.mydomain/favicon.ico', 'path_to_upload_folder' => '/var/www/html/teampass/upload', 'url_to_upload_folder' => 'https://teampass.mydomain/upload', 'path_to_files_folder' => '/var/www/html/teampass/files', 'url_to_files_folder' => 'https://teampass.mydomain/files', 'activate_expiration' => '0', 'pw_life_duration' => '0', 'maintenance_mode' => '0', 'enable_sts' => '1', 'encryptClientServer' => '1', 'cpassman_version' => '2.1.27', 'ldap_mode' => '1', 'ldap_type' => 'windows', 'ldap_suffix' => '@mydomain.com', 'ldap_domain_dn' => 'DC=mydomain', 'ldap_domain_controler' => '172.*******', 'ldap_user_attribute' => '0', 'ldap_ssl' => '0', 'ldap_tls' => '0', 'ldap_elusers' => '0', 'ldap_search_base' => '0', 'ldap_port' => '389', 'richtext' => '0', 'allow_print' => '1', 'roles_allowed_to_print' => '3', 'show_description' => '1', 'anyone_can_modify' => '0', 'anyone_can_modify_bydefault' => '0', 'nb_bad_authentication' => '0', 'utf8_enabled' => '1', 'restricted_to' => '0', 'restricted_to_roles' => '0', 'enable_send_email_on_user_login' => '0', 'enable_user_can_create_folders' => '1', 'insert_manual_entry_item_history' => '0', 'enable_kb' => '0', 'enable_email_notification_on_item_shown' => '0', 'enable_email_notification_on_user_pw_change' => '0', 'custom_logo' => 'https://www.***** ', 'custom_login_text' => '', 'default_language' => 'english', 'send_stats' => '0', 'send_statistics_items' => 'stat_country;stat_users;stat_items;stat_items_shared;stat_folders;stat_folders_shared;stat_admins;stat_managers;stat_ro;stat_mysqlversion;stat_phpversion;stat_teampassversion;stat_languages;stat_kb;stat_suggestion;stat_customfields;stat_api;stat_2fa;stat_agses;stat_duo;stat_ldap;stat_syslog;stat_stricthttps;stat_fav;stat_pf;', 'send_stats_time' => '1594633844', 'get_tp_info' => '1', 'send_mail_on_user_login' => '0', 'sending_emails' => '0', 'nb_items_by_query' => 'auto', 'enable_delete_after_consultation' => '0', 'enable_personal_saltkey_cookie' => '0', 'personal_saltkey_cookie_duration' => '31', 'email_smtp_server' => 'smtp.mydomain.com', 'email_smtp_auth' => '0', 'email_auth_username' => '', 'email_auth_pwd' => '', 'email_port' => '25', 'email_security' => '', 'email_server_url' => '', 'email_from' => 'teampass@mydomain', 'email_from_name' => 'TeamPass', 'pwd_maximum_length' => '40', 'google_authentication' => '0', 'delay_item_edition' => '0', 'allow_import' => '1', 'proxy_ip' => '', 'proxy_port' => '', 'upload_maxfilesize' => '10mb', 'upload_docext' => 'doc,docx,dotx,xls,xlsx,xltx,rtf,csv,txt,pdf,ppt,pptx,pot,dotx,xltx', 'upload_imagesext' => 'jpg,jpeg,gif,png', 'upload_pkgext' => '7z,rar,tar,zip', 'upload_otherext' => 'sql,xml', 'upload_imageresize_options' => '1', 'upload_imageresize_width' => '800', 'upload_imageresize_height' => '600', 'upload_imageresize_quality' => '90', 'use_md5_password_as_salt' => '0', 'ga_website_name' => 'TeamPass for ChangeMe', 'api' => '1', 'subfolder_rights_as_parent' => '1', 'show_only_accessible_folders' => '0', 'enable_suggestion' => '0', 'otv_expiration_period' => '7', 'default_session_expiration_time' => '60', 'duo' => '0', 'enable_server_password_change' => '0', 'ldap_object_class' => '0', 'bck_script_path' => '/var/www/html/teampass/backups', 'bck_script_filename' => 'bck_teampass', 'syslog_enable' => '0', 'syslog_host' => 'localhost', 'syslog_port' => '514', 'manager_move_item' => '0', 'create_item_without_password' => '0', 'otv_is_enabled' => '0', 'agses_authentication_enabled' => '0', 'item_extra_fields' => '0', 'saltkey_ante_2127' => 'none', 'migration_to_2127' => 'done', 'files_with_defuse' => 'done', 'timezone' => 'UTC', 'enable_attachment_encryption' => '0', 'personal_saltkey_security_level' => '50', 'ldap_new_user_is_administrated_by' => '0', 'disable_show_forgot_pwd_link' => '0', 'offline_key_level' => '0', 'enable_http_request_login' => '0', 'ldap_and_local_authentication' => '1', 'secure_display_image' => '0', 'upload_zero_byte_file' => '0', 'upload_all_extensions_file' => '0', 'bck_script_passkey' => '**************************', 'admin_2fa_required' => '1', 'ldap_allowed_usergroup' => '', 'settings_offline_mode' => '1', 'ldap_new_user_role' => '6', 'copy_to_clipboard_small_icons' => '0', ); ``` Insert your webserver log here ``` 172.19.5.129 - - [06/Feb/2024:08:09:41 +0000] "POST /install/upgrade_run_3.0.0.php HTTP/1.1" 200 530 "https://teampassclone.omniaccess.com/install/upgrade.php" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36" 172.19.5.129 - - [06/Feb/2024:08:09:47 +0000] "POST /install/upgrade_run_3.0.0.php HTTP/1.1" 200 1078 "https://teampassclone.omniaccess.com/install/upgrade.php" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36" 172.19.5.129 - - [06/Feb/2024:08:09:48 +0000] "POST /install/upgrade_run_3.0.0.php HTTP/1.1" 200 530 "https://teampassclone.omniaccess.com/install/upgrade.php" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36" 172.19.5.129 - - [06/Feb/2024:08:09:54 +0000] "POST /install/upgrade_run_3.0.0.php HTTP/1.1" 200 1078 "https://teampassclone.omniaccess.com/install/upgrade.php" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36" 172.19.5.129 - - [06/Feb/2024:08:10:00 +0000] "POST /install/upgrade_run_3.0.0.php HTTP/1.1" 200 1078 "https://teampassclone.omniaccess.com/install/upgrade.php" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36" 172.19.5.129 - - [06/Feb/2024:08:10:05 +0000] "POST /install/upgrade_run_3.0.0.php HTTP/1.1" 200 1078 "https://teampassclone.omniaccess.com/install/upgrade.php" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36" 172.19.5.129 - - [06/Feb/2024:08:10:06 +0000] "POST /install/upgrade_run_3.0.0.php HTTP/1.1" 200 530 "https://teampassclone.omniaccess.com/install/upgrade.php" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36" ![image](https://github.com/nilsteampassnet/TeamPass/assets/69692460/1913c193-656c-4536-ab9d-78549d935ae8) Please could you help me? Is this behaviour the expected?
nilsteampassnet commented 8 months ago

@nyevess

I need to rework the full upgrade process. This is my next important task ... please be patient a little more.

nyevess commented 8 months ago

@nilsteampassnet Thanks for your reply, ok we will wait to do the upgrade, when do you think it will be possible, next weeks or next months? Thank you in advance!

nilsteampassnet commented 8 months ago

@nyevess Some tests have run and results seem ok. You could start upgrade but with usage of another instance than production.

nyevess commented 8 months ago

Hello @nilsteampassnet what do you mean by using another instance? we are performing the upgrade on a cloned instance of the production one, but in the last upgrade attempt the process took 12 hours until it hung. Is this normal? Thank you!

Bocholand commented 6 months ago

Hello I had this problem. During the update, I loop in the step the Created_at. I had cleaned up the log to reduce the volume of the base. The script couldn't update the date of creation in table item because the request for find items without date of created and date of created in the table log returned null. 

 "select i.id as id, ls.date as datetime
        from `" . $pre . "items` as i
        inner join `" . $pre . "log_items` as ls on ls.id_item = i.id
        WHERE ls.action = 'at_creation' AND i.created_at IS NULL
        LIMIT " . $post_nb.";"

As it still detects items without date of creation, it lauches a loop again "SELECT * FROM" . $pre . "itemsWHERE created_at IS NULL"

I injected the backup with all the logs into the database and that solved the problem.