nilsteampassnet / TeamPass

Collaborative Passwords Manager
https://www.teampass.net
1.66k stars 540 forks source link

No need to specify CERT_NAME. #4141

Closed paciook closed 5 months ago

paciook commented 5 months ago

Tried to install Teampass with docker-compose and custom SSL certificate but a misconception about the CERT_NAME took me days to figure out.

As said in the jwilder/nginx-proxy dockerhub page at the Wildcard and SNI sections indicate: there's no need to specify a CERT_NAME variable if the VIRTUAL_HOST is a subdomain of the certificate's filename (excluding .crt extension) and even if you want to specify a CERT_NAME, it should be mentioned that:

e.g.

For a VIRTUAL_HOST named foo.bar.com the filename could be bar.com.crt or foo.bar.com.crt and there's no need to have a CERT_NAME. If the file name is other than one of those such as shared.crt, then CERT_NAME should be "shared".

nilsteampassnet commented 5 months ago

Thank you