search

nim-lang / Nim

Nim is a statically typed compiled systems programming language. It combines successful concepts from mature languages like Python, Ada and Modula. Its design focuses on efficiency, expressiveness, and elegance (in that order of priority).
https://nim-lang.org
Other
16.56k stars 1.47k forks source link

Testament important package: regression not reported in testament #24172

Closed mratsim closed 1 month ago

mratsim commented 1 month ago

I'm investigating https://github.com/mratsim/constantine/issues/469.

On the current devel and version2-0 branch this throws: CI version2-0: image

local devel: image

While constantine is NOT in the important packages in version2-0, it is for the current devel, yet the test passes there: image

And the command is the one I used nimble make_lib https://github.com/nim-lang/Nim/blob/3b85c1a2e9b913a11fc7cd202b7e0a617d782cf4/testament/important_packages.nim#L55-L64

Note: there is another regression that I have yet to investigate that results in a compiler crash (see https://github.com/mratsim/constantine/pull/468#issuecomment-2374163248 ) image

This also crashes for constantine v0.1.0 which is the latest tagged version so it's not a devel/tag version difference.

mratsim commented 1 month ago

Found the reason, I was using an unsynced master branch https://github.com/mratsim/constantine/pull/468#issuecomment-2374258761