Fix `tyArray` with 3 kids breaking concept

nim-lang / Nim

Nim is a statically typed compiled systems programming language. It combines successful concepts from mature languages like Python, Ada and Modula. Its design focuses on efficiency, expressiveness, and elegance (in that order of priority).

https://nim-lang.org

Other

16.61k stars 1.47k forks source link

Fix `tyArray` with 3 kids breaking concept #24444

Open Graveflo opened 5 days ago

Graveflo commented 5 days ago

Some types have a tyNone when they have no right hand side of their type definition (like magics array and seq). In some places of the code this appears to have been used like a sentinel value. It seems better to handle this in a different way and not construct invalid objects of these types.

Graveflo commented 4 days ago

thoughts:

the name findUnspecifiedGenericsOrNil sucks
I was unable to get rid of tySeq with 2 kids, but that's probably better off in a different PR anyway