search

nim-lang / NimLime

The official Nim programming language plugin for Sublime Text
MIT License
132 stars 34 forks source link

logpath is wrong; code uses logfile_path #112

Closed timotheecour closed 5 years ago

timotheecour commented 5 years ago

but still after this change, nothing gets written to logfile_path

I'm using this (after having made sure /tmp/nimline.logs is writable); /tmp/nimline.logs/NimLime-Log.txt stays empty

"error_handler.logfile_path": "/tmp/nimline.logs",
Varriount commented 5 years ago

Data is only written to the log file when there's an error - did you test this by causing an error in NimLime?

timotheecour commented 5 years ago

both by reading your code and (IIRC) causing an error:

core/utils/error_handler.py:112:5:    logfile_path = settings.get('error_handler.logfile_path')

so these seem wrong:

NimLime.sublime-settings:8:20:    "error_handler.logpath": "",
core/utils/error_handler.py:48:57:NimLime plugin is writeable, or that the 'error_handler.logpath' setting in

I was gonna make a PR but now you have 2 main branches, master and restructure-for-st3 so not sure which to target (btw I think we should merge to master soon to avoid this; is that meant as a trial period to make sure it all works before pushing to master?)