Closed AmjadHD closed 1 year ago
@Varriount Ping.
https://github.com/nim-lang/Nim/blob/devel/doc/mytest.cfg#L4 Is this valid syntax in nim cfg files ?
One thing that needs to be kept in mind here is that Linguist (GitHub's code highlighter) actually uses NimLime's syntax definitions for code highlighting. Last I checked, Linguist only works with TextMate-compatible grammers, so it doesn't support Sublime Text's additional features.
Yes, I'm aware of that. The sublime-syntax files are for sublime.
@Varriount, review pls.
Is this going to be reviewed any time soon ?
Ping @Varriount
@Varriount, There is a new ST plugin for Nim NimPlus, should I just add the new .sublime-syntax
files there ?
@AmjadHD No, I'll review these changes. Can you give me an overview of what has changed?
@Varriount, The way forward as discussed is to split this repo to two branches one that contains old .tmLanguage
files for github and another that contains .sublime-syntax
files for Sublime Text (and Sublime Merge), so that the testing of each format is seamless.
Can you give me an overview of what has changed?
It's a rework so many things have changed, you can try it and observe the differences for yourself. Otherwise, off the top of my head:
fmt
and &
strings (only for fmt"
not for fmt "
or any other form), better call syntax, highlighting of parameters (proc calls and definitions, tuples and generics), types, const, var, ... sections highlighted (for top level and 2-space indentations only), do syntax, the syntax is faster etc.👋 from github/linguist. This PR has introduced a bug our compiler has just detected whilst I was preparing for the next release:
- [ ] repository `vendor/grammars/NimLime` (from https://github.com/nim-lang/NimLime) (1 errors)
- Grammar conversion failed. File `Syntaxes/Nim CFG.tmLanguage` failed to parse: 1 error(s) decoding:
* 'Repository[block-comments]' expected a map, got 'slice'
@lildude It should be fixed now.
Confirmed. Thanks.
Fix #155 Fix #152 Fix #151 Fix #150 Fix #149 Fix #147 Fix #145 Fix #144 Fix #143 Fix #139 Fix #90 Fix #56 Fix #43