search

nim-lang / NimLime

The official Nim programming language plugin for Sublime Text
MIT License
132 stars 34 forks source link

Split The repo to github and sublime branches #160

Closed AmjadHD closed 1 year ago

AmjadHD commented 1 year ago

We can't rely on the fact that ST ignores a tmLanguage grammar file when a sublime-syntax file with the same name is provided, because we can't modify or test them. The solution is to create 2 branches one for Sublime Text (and Merge) and point Package Control to it. The other is for github and point linguist to it.

AmjadHD commented 1 year ago

@Varriount.

AmjadHD commented 1 year ago

@Varriount can you comment on this ?

Varriount commented 1 year ago

This is why I wanted to stick with the older tmLanguage grammar - having two branches of the language highlighting code invariably means that one will become out of date with the other. I would rather not split the syntax into two branches. Either both variations remain on the same branch, or we just stick with the old tmLanguage grammar.

AmjadHD commented 1 year ago

You can make the github branch the main one, so that it doesn't lag behind despite the fact that there isn't much left to add to the grammar anyway. I'm willing to maintain both grammars.

AmjadHD commented 1 year ago

Also, Is there a need for all the python code ? it didn't work for me and I never used it.

AmjadHD commented 1 year ago

@Varriount.

AmjadHD commented 1 year ago

@Varriount, I need your comment on this.

Varriount commented 1 year ago

@AmjadHD No, I don't like the idea of placing the GitHub-specific code into a separate branch. It makes it too easy to only partially implement updates/fixes.