nim-lang / RFCs

A repository for your Nim proposals.
136 stars 23 forks source link

transfer Varriount/NimLime to nim-lang/NimLime #365

Closed timotheecour closed 3 years ago

timotheecour commented 3 years ago

proposal

transfer https://github.com/Varriount/NimLime to https://github.com/nim-lang/NimLime see https://github.com/Varriount/NimLime/issues/154 for rationale and prior discussion:

I'm in favor of this since I have no time to continue maintaining it. We should be looking for new maintainers if varriount is also unable to maintain

I've already created a fork https://github.com/nim-lang/NimLime tentatively, if there's no objection then we can move issues and PRs (only 1 pending, https://github.com/Varriount/NimLime/pull/153, which supports the new literals) to the new location (see how in https://hub.packtpub.com/github-now-allows-issue-transfer-between-repositories-a-public-beta-version/), but IIRC it needs to be done by someone with admin access to both repos.

Varriount commented 3 years ago

Just want to chime in: I'm 100% ok with this (assuming we're allowed access to the repo).

Someone will have to work to change where GitHub's Nim highlighting definitions are sourced from (as far as I know, they're still sourced from the NimLime syntax definition files).

timotheecour commented 3 years ago

Someone will have to work to change where GitHub's Nim highlighting definitions are sourced from (as far as I know, they're still sourced from the NimLime syntax definition files).

see https://github.com/github/linguist/pull/5306 which was needed to support the new number literals, and changed from https://github.com/Varriount/NimLime to https://github.com/timotheecour/NimLime as a temporary measure, but once Varriount/NimLime is transfered to nim-lang/NimLime, we'll need to update again the submodule as followup to https://github.com/github/linguist/pull/5306

The next action item right now is for an owner of https://github.com/Varriount/NimLime to transfer issues and PRs from Varriount/NimLime to nim-lang/NimLime, using https://hub.packtpub.com/github-now-allows-issue-transfer-between-repositories-a-public-beta-version/ or equivalent so that issue metadata are preserved

Araq commented 3 years ago

So ... do I need to do anything to make this happen?

timotheecour commented 3 years ago

@Varriount can you please make @Araq an owner of your repo and then @araq can transfer the repo using:

https://github.com/Varriount/NimLime/settings > Danger Zone > Transfer ownership

Transfer this repository to another user or to an organization where you have the ability to create repositories.

image

(i'm not sure whether the fork i made in https://github.com/nim-lang/NimLime needs to be deleted first)

Varriount commented 3 years ago

@Varriount can you please make @Araq an owner of your repo and then @Araq can transfer the repo using:

https://github.com/Varriount/NimLime/settings > Danger Zone > Transfer ownership

Transfer this repository to another user or to an organization where you have the ability to create repositories.

image

(i'm not sure whether the fork i made in https://github.com/nim-lang/NimLime needs to be deleted first)

Ah, sorry. It hadn't occurred to me that I would need to do anything. Should be done in a moment.

I'll need to work with Package Control to move the link in that repo as well.

Edit: Someone will need to delete or rename the current fork Nim-Lang has.

timotheecour commented 3 years ago

@Varriount

Edit: Someone will need to delete or rename the current fork Nim-Lang has.

done (i had created the fork recently and checked that nothing was added to it before removing the fork); what else should be done?

I'll need to work with Package Control to move the link in that repo as well.

can you document the steps you're taking or link to some docs? thanks!

timotheecour commented 3 years ago

ping @Varriount

AmjadHD commented 3 years ago

@timotheecour https://packagecontrol.io/docs in short this url should be updated (through a PR) https://github.com/wbond/package_control_channel/blob/836c004d544830ab89c50c09d61e3dc7d3f2a7b7/repository/n.json#L629

timotheecour commented 3 years ago

looks like the repo, issues, PRs were successfully migrated, thanks! next steps: