search

nim-lang / atlas

The Atlas Package cloner. It manages an isolated workspace that contains projects and dependencies.
MIT License
99 stars 14 forks source link

Hack in branch support #40

Closed SirOlaf closed 9 months ago

SirOlaf commented 1 year ago

Works, but kinda nasty. Would appreciate some feedback

Araq commented 1 year ago

What is the goal?

Araq commented 1 year ago

I would much rather see: requires "x >= #hashX & <= #hashY | >= #hashA & <= #hashB". Then we can use tiny packages more effectively that are not tagged.

SirOlaf commented 1 year ago

The goal was actually langserver which uses branches, so either its lockfile must be used or branches need to work https://github.com/nim-lang/langserver/blob/master/nimlangserver.nimble#L12

That said just making branches work wasn't quite enough because of a weird relative import

Araq commented 1 year ago

We can also just fix/change langserver instead.

elcritch commented 1 year ago

Branches are pretty common during development and team work as well. It's really handy to change requires "foo" to requires "foo#feature-branch" so others can work with it as well.

Araq commented 9 months ago

If desired, needs to be redone again now that we have the new dependency graph. Sorry.