nim-lang / bigints

BigInts for Nim
MIT License
124 stars 32 forks source link

Version is 1.0.0 but latest tag is 0.5.0 #115

Closed rotu closed 2 years ago

rotu commented 2 years ago

Originally, reported in https://github.com/FedericoCeratto/nim-package-directory/issues/50, the package directory incorrectly lists this package as 0.5.0. As per Nimble's documentation, the version number needs to be bumped via git tag.

dlesnoff commented 2 years ago

@narimiran Could you bump the minor version with a git tag to 0.6.0 ? (Git documentation about tags, I guess an annotated tag is better ) See #117 users are confused since nimble install bigints installs a now very old version.

rotu commented 2 years ago

@dlesnoff the version is currently 1.0.0 https://github.com/nim-lang/bigints/blob/d843ecfe1e2a62c3b0e29d211df09763da408cac/bigints.nimble#L3

The cardinal rule of versioning is that numbers always go up. So I think the next tagged version should be >1.0.0, not 0.6.0

Grench6 commented 2 years ago

@dlesnoff The existing tags are already lightweight, so I see no major benefit from changing to annotated tags.

I agree with @rotu: since all the old commits have version 1.0.0 on it, I think it would be better to increase it instead of decreasing it... its too late for that. Otherwise it will be even more confusing for people who is trying to understand the project history.

narimiran commented 2 years ago

v1.0.0 tag pushed.

rotu commented 2 years ago

Confirmed the changes are reflected at https://nimble.directory/pkg/bigints