search

nim-lang / bigints

BigInts for Nim
MIT License
124 stars 32 forks source link

Update CI to check 1.6.4 #97

Closed konsumlamm closed 2 years ago

dlesnoff commented 2 years ago

I am pretty sure stable version is already 1.6.2. I do not see why we should remove 1.6.0 support.

konsumlamm commented 2 years ago

True, stable is currently 1.6.2, so I guess checking 1.6 at all (or checking stable) is a bit redundant.

However, 1.6.2 is 1.6.0 with bug fixes, I don't see why we should keep 1.6.0 support.

dlesnoff commented 2 years ago

You are right, we should remove 1.6.0 support. EDIT : realized there is a problem if a new Nim version releases. It is interesting in that case to have both 1.6.2 and stable, since it will automatically test for the new Nim release and keep old version checks. Maybe we should remove stable instead, and update versions manually. In any case, we will have to remove old versions manually.

narimiran commented 2 years ago

Btw, 1.6.4 is around the corner.

konsumlamm commented 2 years ago

Btw, 1.6.4 is around the corner.

So should I rather wait for that?

narimiran commented 2 years ago

So should I rather wait for that?

Yeah, keep this open and once the 1.6.4 is out, we'll update and merge it.

konsumlamm commented 2 years ago

@narimiran since 1.6.4 is out now, I updated the PR. I also removed stable, since that's 1.6.4 anyway and this way we can explicitly state the supported versions.