nim-lang / checksums

Hash algorithms in Nim
MIT License
13 stars 4 forks source link

Inconsistent data types for update procs and for digests #15

Open sgmihai opened 5 months ago

sgmihai commented 5 months ago

for context upate procs data types: md5 has openArray[uint8], the others have: openArray[char]

for digest types: md5: array[uint8] sha1: array[uint8] sha2: array[char] sha3: array[char]

Is there any good reason for this ? Feels to me that they should all be uint8