search

nim-lang / choosenim

Official tool for easily installing and managing multiple versions of the Nim programming language.
BSD 3-Clause "New" or "Revised" License
36 stars 8 forks source link

https://nim-lang.org/choosenim/init.sh is outdated #49

Closed SpotlightKid closed 4 weeks ago

SpotlightKid commented 4 weeks ago

https://nim-lang.org/choosenim/init.sh needs to be updated to the latest version in the repo. It is missing the latest changes in commit ac77dc5 "supports arm64 on macOS" .

This means that on macOS arm64 it still downloads the amd64 choosenim binary.

See also: https://github.com/dom96/choosenim/issues/347

ringabout commented 4 weeks ago

Well, it has been linked to https://github.com/nim-lang/choosenim/blob/master/scripts/choosenim-unix-init.sh in the server

SpotlightKid commented 4 weeks ago

When I download the file (with curl -O) , I still get the version, which has this on line 127ff.:

      if [ "$HOSTTYPE" = "arm64" ] ; then
        # TODO: We don't have arm binaries for choosenim so far, rely on Rosetta.
        local ucpu="amd64"
      fi

which is the previous version.

ringabout commented 4 weeks ago

@SpotlightKid Sorry for the inconvenience. We have had fixed it on the server. Does it work for you now?

SpotlightKid commented 4 weeks ago

Yes, an up-to-date init.sh is downloaded now. I don't have macOS so I can't test whether it downloads the right binary for macOS arm64 now, but it should.

ringabout commented 3 weeks ago

https://github.com/nim-lang/choosenim/pull/55 will be added to ensure it works on macosx_arm