nim-lang / fusion

Fusion is for now an idea about how to grow Nim's ecosystem without the pain points of more traditional approaches.
MIT License
128 stars 16 forks source link

[!!!] Rename `*Table` types to `*Map` #34

Closed haxscramper closed 3 years ago

haxscramper commented 3 years ago

Reasoning described in #31

There is absolutely no consistency in any other language in terms of naming ordered/unordered associative containers (some call trees maps, some hashes, some use both names, sometimes neither of the names are used), so it was mostly just arbitrary decision to name it Map. Adding "BTree" or "Binary" prefix is probably not really useful anyway, since it makes type ~2 longer to type without bringing any benefit over Map.

juancarlospaco commented 3 years ago

Needs changelog.

planetis-m commented 3 years ago

Anyone else has an opinion if this rename is necessary?

liquidev commented 3 years ago

I'd prefer if the btreetables were renamed to BinaryTable or TreeTable, Map is not descriptive enough in my opinion.

haxscramper commented 3 years ago

I don't really care about exact naming - BTable, or TreeTable or Map or SortedTable or whatever - just not the same as std/tables.Table.

Araq commented 3 years ago

Rejected for multiple reasons: