search

nim-lang / fusion

Fusion is for now an idea about how to grow Nim's ecosystem without the pain points of more traditional approaches.
MIT License
128 stars 16 forks source link

fusion CI should run tests and docs for js #63

Closed timotheecour closed 3 years ago

timotheecour commented 3 years ago

refs https://github.com/nim-lang/fusion/pull/59#pullrequestreview-560240257

otherwise PR's like this https://github.com/nim-lang/fusion/pull/59 have tests that are never run.

Furthermore, we need to publish docs for js-only modules

/cc @juancarlospaco

juancarlospaco commented 3 years ago

We need someone to merge https://github.com/nim-lang/fusion/pull/54#issue-539041687 ?. So it can advance further, or should it be mixed in between of that. :thinking:

timotheecour commented 3 years ago

ok! refs https://github.com/nim-lang/fusion/pull/54#issuecomment-753559215

timotheecour commented 3 years ago

Done, merged

timotheecour commented 3 years ago

also related but can be fixed independently: https://github.com/timotheecour/Nim/issues/197

timotheecour commented 3 years ago

closing since https://github.com/nim-lang/fusion/pull/64 mostly addressed this, will re-open a new issue to track the rest: https://github.com/nim-lang/fusion/issues/71