nim-lang / fusion

Fusion is for now an idea about how to grow Nim's ecosystem without the pain points of more traditional approaches.
MIT License
128 stars 16 forks source link

matching: Consider nnkTupleConstr as tuple #86

Closed Clyybber closed 3 years ago

Clyybber commented 3 years ago

A small fix on current devel, and required for https://github.com/nim-lang/Nim/pull/13793

timotheecour commented 3 years ago

@Clyybber instead, use when defined(nimHasUnifiedTuple) which was introduced in https://github.com/nim-lang/Nim/pull/13793 to maintain stricter checks

Clyybber commented 3 years ago

Being more strict would be wrong, see https://github.com/nim-lang/fusion/blob/master/src/fusion/matching.nim#L1146

timotheecour commented 3 years ago

ok, will take your word for it :)