search

nim-lang / nightlies

Separate repository to trigger installer builds.
MIT License
44 stars 14 forks source link

Fix Windows Build #29

Closed nc-x closed 5 years ago

nc-x commented 5 years ago

Windows build is failing because the sqlite dlls are in bin folder, whereas koch boot builds nim in the compiler/ folder. So either the dlls need to be copied over there, or bin/ should be in path.

ping @narimiran @genotrance

Refs https://forum.nim-lang.org/t/5105

genotrance commented 5 years ago

@Araq wanted to use windeps going forward. Might be better to just add the dlls to it instead. Still need the path addition though.

Same issue is on arm builds as well but need to build sqlite from scratch for those.

nc-x commented 5 years ago

@genotrance actually, windeps has the dlls but they are not getting used for some reason. Maybe they are outdated or something. That's why I changed to dlls.zip in the last commit for testing. If it works, then windeps need to be updated.

So basically, I don't know bash/linux.

genotrance commented 5 years ago

You might want to give the full path instead of relative. Travis uses bash.

nc-x commented 5 years ago

@genotrance yeah, I fixed that with realpath. The windows build passes now.