nim-lang / nightlies

Separate repository to trigger installer builds.
MIT License
44 stars 14 forks source link

Add 'koch testinstall' for linux/osx #4

Closed kaushalmodi closed 5 years ago

kaushalmodi commented 6 years ago

https://gitter.im/nim-lang/Nim?at=5bc9004d069fca52a5598a63

kaushalmodi commented 6 years ago

@Araq I tried adding koch testinstall, but it is failing with this error:

./koch tests
bin/nim cc --taintMode:on --opt:speed testament/tester
Error: unhandled exception: No such file or directory [OSError]
FAILURE
FAILURE

Full log - *Search for [phase 6 to directly reach the koch testinstall part.

I have removed that command from my experiment repo for now, but this is how it looked before I removed those lines:

https://github.com/kaushalmodi/nightlies/blob/ff99a34cf7ac83674e7aec5ea8df24c933cc03c4/.travis.yml#L64-L65

kaushalmodi commented 6 years ago

Looks like the testament/ dir is not getting packed into the tar.xz at all.

kaushalmodi commented 6 years ago

Looks like the compiler/installer.ini needs to be thoroughly reviewed and updated. Probably testament needs to be added here to fix this?

https://github.com/nim-lang/Nim/blob/cd9bc941e1315f47efd1ec567249a16347c0319a/compiler/installer.ini#L91

@Araq

Araq commented 6 years ago

Looks like the compiler/installer.ini needs to be thoroughly reviewed and updated. Probably testament needs to be added here to fix this?

Exactly, consider it done.

kaushalmodi commented 6 years ago

Ref: https://github.com/nim-lang/Nim/commit/00f84d3d22cdeed7b4a2060e6307e3a742729055

kaushalmodi commented 5 years ago

@genotrance The initial goal for the nighties will be considered "done" once "koch testinstall" passes on all platforms. If you don't get to this earlier, I'll try running "koch testinstall" later today to see it has now started passing.

kaushalmodi commented 5 years ago

koch testinstall times out Travis at just 50 mins:

https://api.travis-ci.org/v3/job/474484670/log.txt

progress[all]: i: 107 / 110 cat: examples
testament/tester --nim:compiler/nim pcat examples 

The job exceeded the maximum time limit for jobs, and has been terminated.
kaushalmodi commented 5 years ago

@Araq mentioned here that a workaround for this timeout would be to limit koch testinstall to run only "megatest".

kaushalmodi commented 5 years ago

Look into Travis Build Stages to see if that circumvents with timeout issue: https://gitter.im/nim-lang/Nim?at=5c2cd7e42863d8612bc9113d

kaushalmodi commented 5 years ago

Putting the timeout issue aside, I also see koch testinstall failing many tests because of "nodejs binary not in PATH".

https://api.travis-ci.org/v3/job/474484670/log.txt

testament/tester --nim:compiler/nim pcat arithm 
JOINED: tests/arithm/tarithm.nim C
PASS: tests/arithm/tashr.nim C                                     ( 0.83025384 secs)
FAIL: tests/arithm/tashr.nim JS
Test "tests/arithm/tashr.nim" in category "arithm"
Failure: reExeNotFound
Expected:


Gotten:
nodejs binary not in PATH

FAILURE! total: 3 passed: 1 skipped: 1 failed: 1
Araq commented 5 years ago

koch testinstall now works.