search

nim-lang / nim-mode

An emacs major mode for the Nim programming language
139 stars 46 forks source link

Refactor for debugging #113

Closed yuutayamada closed 8 years ago

yuutayamada commented 8 years ago

At #108, I realized current nim-mode wasn't easy to distinguish problems. (whether it's nimsuggest related or font-lock related, for example)

This PR allows users easy setting to turn off some feature for nim-mode

  1. turn off nimsuggest: (defconst nim-nimsuggest-path nil)
  2. turn off syntax-highlight: (defconst nim-font-lock-keyword-list nil) (this feature didn't pass test, so I removed from this PR)
reactormonk commented 8 years ago

Do you want to use nim-suggest or nimsuggest for nimsuggest related stuff?

yuutayamada commented 8 years ago

For namespacing of emacs, I would use nim-suggest-* for stuff related to nim-suggest.el and I think the nim-nimsuggest- (probably it's only used at nim-nimsugest-path) should be changed to other name space.

But we already wrote the nim-nimsugest-path to the README.md, so I'm not sure how we should change... (should change it to obsolete variable? and make new variable?)

yuutayamada commented 8 years ago

(I just found a typo and fixed)

reactormonk commented 8 years ago

I'd say keep the stuff in the readme and do what you prefer in the internals.

yuutayamada commented 8 years ago

Okay, thanks.

yuutayamada commented 8 years ago

@reactormonk fixed