nimsuggest wrong-type-argument stringp

kaushalmodi commented 7 years ago

This is probably related to https://github.com/nim-lang/nim-mode/issues/154 but am not 100% sure.

For this simple code where I was experimenting with noSideEffect:

proc sum(x, y:int): int {. noSideEffect .} =
  echo x # causes side effect
  x + y

echo sum(2,3)

I get this in the *Messages* buffer instead of having that error show up in *Flycheck errors* buffer.

Error from syntax checker nim-nimsuggest: (wrong-type-argument stringp ((chk skUnknown nil /home/kmodi/sandbox/nim/sideeffectchecking.nim Error 1 5 'sum' can have side effects 0)))

OS: RHEL 6.6
Emacs: version 26+, built from master branch
Nim: v0.17.0 (verified that this issue occurs for v0.16.0 too) (git hash: d3f0f87e81e262ee25fd528aae5b6db0bdf78d5e, active boot switches: -d:release)
nimsuggest: v0.17.0 (verified that this issue occurs for v0.16.0 too) (git hash: d3f0f87e81e262ee25fd528aae5b6db0bdf78d5e, active boot switches: -d:release --gc:markAndSweep)
nim-mode: latest version from Melpa

[x] Are you using latest version of nim-mode?
- Yes
[x] Are there message related to nim-mode in *Messages* buffer?
- No. There are errors that I pasted above, and also Invalid face reference: face each time I put the point on proc sum(x, y:int): int {. noSideEffect .} =.
[x] Did you read README.md?
- Yes.
[x] Is your problem related to nimsuggest-mode? (company-mode, flycheck, or el-doc)
- Probably not nimsuggest-mode, because I removed nimsuggest-mode from nim-mode-hook, and also verified that the value of nimsuggest-mode then showed nil, and the value of nim-mode-hook was '(flycheck-mode nim-capf-setup nlinum-mode).
- [x] Did you try nim-mode without nimsugggest-mode? What happened?
  - Still got the same problem.

Some more digging:

With nimsuggest-mode and flycheck-mode enabled, I get:
- Error from syntax checker nim-nimsuggest: (wrong-type-argument stringp ((chk skUnknown nil /home/kmodi/sandbox/nim/sideeffectchecking.nim Error 1 5 'sum' can have side effects 0))), and
- Invalid face reference: face
With nimsuggest-mode disabled, the invalid face reference issue goes away but the earlier error still show up.
With flycheck-mode disabled too, all errors go away.

So the problem is somewhere in flycheck-nimsuggest.el.

kaushalmodi commented 7 years ago

The Invalid face issue discussion moved to a separate issue: https://github.com/nim-lang/nim-mode/issues/161

kaushalmodi commented 7 years ago

This issue does in fact become the exact same as https://github.com/nim-lang/nim-mode/issues/154 if I remove the {. noSideEffect .} pragma from the code:

proc sum(x, y:int): int =
  echo x # causes side effect
  x + y

echo sum(2,3)

nim-lang / nim-mode

nimsuggest wrong-type-argument stringp #160