Dropping support under Emacs 24 or lower

nim-lang / nim-mode

An emacs major mode for the Nim programming language

138 stars 46 forks source link

Dropping support under Emacs 24 or lower #178

Open yuutayamada opened 6 years ago

yuutayamada commented 6 years ago

After Emacs 26 is released.

I will clean up or take care some stuff of:

[x] I added release tag v0.4.0, so nim-mode's git users or MELPA stable users can go back now if they need
[ ] if-let/when-let -> if-let/when-let
[ ] let-alist (built in from Emacs 25)
[ ] ugly xref work around
[ ] move flycheck-nimsuggest to other repo (for less dependencies
[ ] and support flymake package default
[ ] modify editor page's requirement version of Emacs
[ ] I might add something later

jaccarmac commented 6 years ago

ugly xref work around

This bit me today and I could take a crack at it if you clarify exactly why the hack exists at this time.

yuutayamada commented 6 years ago

you can use M-? command (find-reference) from Emacs 25.1, but I added this feature recently, so might have bug. please file a issue.

jaccarmac commented 6 years ago

OK, I was trying to use M-.. Will try again when I have access to the codebase tomorrow and will file a new ticket if there are problems.

yuutayamada commented 6 years ago

@jaccarmac I merged some fixes. hope your issue fixed as well. (probably it may take a while if you use MELPA)

jaccarmac commented 6 years ago

I do not and will check them out tomorrow. Thanks!

jaccarmac commented 6 years ago

The function works now but doesn't actually return any results, even if the definition is in the same file. I will open up a new issue for it after investigating further.