search

nim-lang / nim-mode

An emacs major mode for the Nim programming language
138 stars 46 forks source link

Append space to comment start #190

Closed avsej closed 5 years ago

avsej commented 6 years ago

It saves keystrokes, and also it is a good style to havethat space after comment anyway

yuutayamada commented 6 years ago

Sorry, I'm not sure what this PR changes. Can you please describe what are you trying to do? (I tried comment-dwim, but it seems already insert a space after the hash)

avsej commented 6 years ago

I just got used to ruby-mode and python-mode, where space inserted and cursor moved to next character position. I guess many modes do this, and wonder why nim-mode does not.

https://github.com/emacs-mirror/emacs/blob/786907238bcb86ab9e0e2e9ebcc91c52a6eb024c/lisp/progmodes/python.el#L5306 https://github.com/emacs-mirror/emacs/blob/786907238bcb86ab9e0e2e9ebcc91c52a6eb024c/lisp/progmodes/ruby-mode.el#L754

yuutayamada commented 6 years ago

Can you tell me how to make sure the space inserted? I need to make sure it because nim uses "##" as doc comment.

krux02 commented 5 years ago

For me it is totally unclear what that change might have for an effect. Since fill-paragraph does insert a space at the start of a comment I don't see any problem that is fixed with this change. Since here is also no activity I would like to close this.

krux02 commented 5 years ago

I close it now.