search

nim-lang / nim-mode

An emacs major mode for the Nim programming language
138 stars 46 forks source link

Why is flycheck-nimsuggest a separate module? #204

Closed krux02 closed 5 years ago

krux02 commented 5 years ago

This is just a question. Is there any reason to not bunled the flycheck backend with nim-mode?

In the comments I found some lines that flymake is the reason. But I don't understand does the flycheck backend being part of nim-mode cause a conflict in nim-mode?

yuutayamada commented 5 years ago

I just prefer maintaining emacs-core's package in nim-mode. It's not due to conflict. I would prefer separating issue tracker for flycheck stuff.

krux02 commented 5 years ago

Personally I think it's easier for tho average nim-user, when both is combined in a single install. Subjectively I think currently neither nimsuggest nor nim-mode are big enough to justify a project split.

yuutayamada commented 5 years ago

It's hard for me they are making issue that coming from flycheck, flymake, nimsuggest, or just their personal configuration. I would reduce the possibility as much as I can.

krux02 commented 5 years ago

While that is true, I don't think that separating the project helps here a lot, because just because you split the project, it doesn't mean that the user now automatically knows from where the bug came from. When it is one project the user at least knows where to create the issue, because it is less ambiguous.

yuutayamada commented 5 years ago

I think it helps because users need to specify flycheck-nimsuggest from package manager. At least they chose it to install and it's easy to segment for typical users if the problem come from flycheck. (just deleting flycheck-nimsuggest)

krux02 commented 5 years ago

Well, ... I still don't like the split. But I guess I can't convince you to merge it back in nim-mode, can I?

yuutayamada commented 5 years ago

Sorry I wouldn't