search

nim-lang / nim-mode

An emacs major mode for the Nim programming language
138 stars 46 forks source link

Fix extracting the frame number #218

Closed recloser closed 6 years ago

recloser commented 6 years ago

The code incorrectly assumed that the frame number is going always to be at the third place in the split string, but the emacs frame title which is included in the string extracted with (selected-frame) can actually be customized using the frame-title-format var and might include spaces.

On Windows this actually made the extension completely unusable for me, since it erroneously extracted the full file path from my customized frame title which made it impossible to create the necessary temp file (on Windows filenames can't include colons like in C:\foo.nim).

krux02 commented 6 years ago

Generally I would prefer if you would have removed the format and split-string handling entirely. But I am OK with the change as it is right now.