search

nim-lang / nim-mode

An emacs major mode for the Nim programming language
137 stars 46 forks source link

fix(rx): Byte compile error #248

Closed jcs090218 closed 10 months ago

jcs090218 commented 10 months ago

For #247

Vindaar commented 10 months ago

Do you have any idea why the previous code worked in the past?

Tested your code locally and it fixes the error. But I must admit I don't fully understand it, in particular why we need the eval there.

jcs090218 commented 10 months ago

Do you have any idea why the previous code worked in the past?

I don't know if the previous code worked or not. However, when Emacs fails to compile code, it will eval the source code instead since no .elc file is generated. 🤔

I only know this PR works because I eval the old and new code simultaneously, and it gives me the same result.

Vindaar commented 10 months ago

Heh, fair enough. Thanks a lot!