Closed Clonkk closed 3 years ago
I would go even further in the reorganization:
Which CI is available (Azure or Travis I assume) ? Is there a yaml template to follow ?
@Araq I think this PR is ready for review.
Since we went for a 1.0 :
ZTypeName
(prefix to avoid name conflict)context
, socket
I used github actions based on https://github.com/iffy/install-nim. If that's not the preferred way for CI, I'd be happy to change it to whatever is standard for "official" repository. The github actions simply uses testament to run the tests and examples.
There is no documentation generation for now as I'm not sure how you want to handle it for this repo (I usually use github pages on docs/
folder and commit the generated files).
len > 0
insend
beforecopyMem
[]
andevents()
andlen()
for poller to simplify polling code (having to manually deal with bitops is poor IMO)when defined(gcDestructors)
, closePSocket
and ownedPContext
sockaddr
that keep in memory the address of the TConnectiondisconnect
,unbind
proc somehow needs the addressThe only API change is adding 2 fields to the type
TConnection
. No proc changed signature - just more proc added to improve the quality of life.@Araq (or any maintainer that read this) at your leisure, I'd like have your opinion on the change before I spend any more time on this.