nim-lang / nim-zmq

Nim ZMQ wrapper
https://nim-lang.github.io/nim-zmq/zmq.html
MIT License
67 stars 17 forks source link

Reorganize repo #24

Closed Clonkk closed 3 years ago

Clonkk commented 3 years ago

The only API change is adding 2 fields to the type TConnection. No proc changed signature - just more proc added to improve the quality of life.

@Araq (or any maintainer that read this) at your leisure, I'd like have your opinion on the change before I spend any more time on this.

Araq commented 3 years ago

I would go even further in the reorganization:

Clonkk commented 3 years ago

Which CI is available (Azure or Travis I assume) ? Is there a yaml template to follow ?

Clonkk commented 3 years ago

@Araq I think this PR is ready for review.

Since we went for a 1.0 :

I used github actions based on https://github.com/iffy/install-nim. If that's not the preferred way for CI, I'd be happy to change it to whatever is standard for "official" repository. The github actions simply uses testament to run the tests and examples.

There is no documentation generation for now as I'm not sure how you want to handle it for this repo (I usually use github pages on docs/ folder and commit the generated files).