Closed Clonkk closed 3 years ago
For some reason (I thought I fixed it, but apparently not) the CI sometimes fails and hang indefinitely. I'll reopen this when I can do something. I'll reopen when it's fixed on my fork.
Apparently closing PR do not cancel associated jobs so https://github.com/nim-lang/nim-zmq/actions/runs/1067646494 will probably have to be cancelled manually.
Network testing on github CI is volatile; since running the examples wasn't really necessary so I ended making sure the examples compile but without running them.
Should the async proc be called sendAsync
receiveAsync
or æsyncSend
, asyncReceive
to be consistent with other async package ?
@Clonkk I have no opinions on naming. There reasons why I put the procs in /test as an example and aside from zmq is that it makes asyncdispatch
module as a required dependence. It seems to me that not everyone use (or like) std/asyncdispatch as their async task runner. And it is easy to copy-and-paste if users have read the examples.
I have no opinion on the names either.
Fix a missing a close in examples that could cause CI to hang indefinitelyapparently not fixedgh-pages
branchgh-pages
branch on thedocs
folder.=> If you don't want to generate the docs, this can be removed from this PR.