nim-lang / nim-zmq

Nim ZMQ wrapper
https://nim-lang.github.io/nim-zmq/zmq.html
MIT License
67 stars 17 forks source link

Adding async to zmq package #27

Closed Clonkk closed 3 years ago

Clonkk commented 3 years ago

=> If you don't want to generate the docs, this can be removed from this PR.

Clonkk commented 3 years ago

For some reason (I thought I fixed it, but apparently not) the CI sometimes fails and hang indefinitely. I'll reopen this when I can do something. I'll reopen when it's fixed on my fork.

Clonkk commented 3 years ago

Apparently closing PR do not cancel associated jobs so https://github.com/nim-lang/nim-zmq/actions/runs/1067646494 will probably have to be cancelled manually.

Network testing on github CI is volatile; since running the examples wasn't really necessary so I ended making sure the examples compile but without running them.

Clonkk commented 3 years ago

Should the async proc be called sendAsync receiveAsync or æsyncSend, asyncReceive to be consistent with other async package ?

jackhftang commented 3 years ago

@Clonkk I have no opinions on naming. There reasons why I put the procs in /test as an example and aside from zmq is that it makes asyncdispatch module as a required dependence. It seems to me that not everyone use (or like) std/asyncdispatch as their async task runner. And it is easy to copy-and-paste if users have read the examples.

Araq commented 3 years ago

I have no opinion on the names either.