Feat async poller - Githubissues

nim-lang / nim-zmq

Nim ZMQ wrapper

https://nim-lang.github.io/nim-zmq/zmq.html

MIT License

65 stars 17 forks source link

Feat async poller #32

Closed Clonkk closed 2 years ago

Clonkk commented 2 years ago

Add an async version of a ZMQ poller with a callback associated
Add explicit cstring converter to avoid warning
Fix typo in listen / connect (also addressed by https://github.com/nim-lang/nim-zmq/pull/30)
Bump nimble version to 1.3.0

@Araq (or @xflywind or whoever is best suited), at your leisure, could you check the implementation of the async poller (there's a tests in tzmq added) as I'm not an async expert ?

Araq commented 2 years ago

Sorry but I am not competent enough to review this. How about we merge it but make it explicit in the code that it is experimental?

Clonkk commented 2 years ago

Sorry but I am not competent enough to review this. How about we merge it but make it explicit in the code that it is experimental?

Sure, that seems like a good option. Should htis be added as a docstring or maybe as an experimental pragmas ?

Araq commented 2 years ago

Docstrings please.